Closed eevadai closed 2 years ago
I haven't reviewed the whole Pull Request yet, but some initial comments:
main
, you should change your merge branch into main
, as Scott has identified earlier. [+]
, [-]
, [*]
, to denote addition of features, removal of features, and modification of features respectively. Holding the convention may help us refactor our code later on in the process. .DS_Store
within your commit. This is an absolutely useless file generated by MacOS that keeps your desktop icons in their location. You can choose not to include them in your IDE, which keeps our project clean. Closing this pull request as it is duplicated with this pull request.
In this case, you should merge the commit into the main branch.
You can hit the edit button and change the base branch to the main branch.
@eevadai