confusing naming addAllUser

[Hclover2003]

Should we change the name of the addAllUser method in UserList to just addUser?

Right now, the name seems to imply it adds multiple users at once to the database, but it actually just adds one.

[Hclover2003]

Just a note for now - we should probably refactor naming last to avoid unexpected naming troubles

[Hclover2003]

Similarly, in userGateway, where we are saving multiple users (saveUser saves a UserList with multiple users to the database), maybe we can rename it as well?

• saveUser makes it seem like we are saving one user to the database. Maybe something like saveUserList or saveUsers?

[YadingF]

Okay, I will explain carefully on the Javadoc, I think it would be hard to change the name now since many classes(not only users) that used this method might need to change the reference name too(so may cause many unpredicted problems), but thank you for letting me know, I will definitely pay more attention to the Javadoc, sorry to cause this confusion.

---

发件人: Huayin Luo @.> 发送时间: 2022年11月30日 1:26 收件人: CSC207-2022F-UofT/course-project-collegecook @.> 抄送: Yading Feng @.>; Assign @.> 主题: Re: [CSC207-2022F-UofT/course-project-collegecook] confusing naming addAllUser (Issue #75)

Similarly, in userGateway, where we are saving multiple users (saveUser saves a UserList with multiple users to the database), maybe we can rename it as well?

• saveUser makes it seem like we are saving one user to the database. Maybe something like saveUserList or saveUsers?

― Reply to this email directly, view it on GitHubhttps://github.com/CSC207-2022F-UofT/course-project-collegecook/issues/75#issuecomment-1331016525, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A26QZARIMI6SCF5NU6MAV4TWKY4D3ANCNFSM6AAAAAASOXMBPQ. You are receiving this because you were assigned.Message ID: @.***>

[Hclover2003]

I agree, this doesn't affect the functionality, more of a change if we have time reformatting note Thanks!

[YadingF]

Clearly indicated on the Javadoc