CSC207-2022F-UofT / course-project-hello-woooorld-119

course-project-hello-woooorld-119 created by GitHub Classroom
0 stars 0 forks source link

2 user intefaces #12

Closed ec105 closed 1 year ago

ec105 commented 1 year ago

Combing user intefaces to main branch completed structuing : UIinsidechatroom UIinsidechatroom_backend UIoutsidechatroom UIoutsidechatroom_backend Loginpage Loginusecase user

ec105 commented 1 year ago

Why are we gathering the username and password from the command line?

it is needed for loginsystem, when we init the user object, we assumed it is created when username and password and them both should be saved

hu-jeff commented 1 year ago

Why are we gathering the username and password from the command line?

it is needed for loginsystem, when we init the user object, we assumed it is created when username and password and them both should be saved

But why are we getting this information from the command line? We should be getting it from the UI. I think we need parameters that call that function that are the username and password.

ec105 commented 1 year ago

Why are we gathering the username and password from the command line?

it is needed for loginsystem, when we init the user object, we assumed it is created when username and password and them both should be saved

But why are we getting this information from the command line? We should be getting it from the UI. I think we need parameters that call that function that are the username and password.

the info is received from the UI, but just need to be stored in User class when initializing

hu-jeff commented 1 year ago

Why are we gathering the username and password from the command line?

it is needed for loginsystem, when we init the user object, we assumed it is created when username and password and them both should be saved

But why are we getting this information from the command line? We should be getting it from the UI. I think we need parameters that call that function that are the username and password.

the info is received from the UI, but just need to be stored in User class when initializing

The beginlogin function loops infinitely until there is a response in the console.

SamandarVijay commented 1 year ago

Sam's portion should be to submit the login.

In the LoginPage, line 31. Why are we using a loop for the login system? It seems no matter what the loop only runs once. Furthermore, to check if a login is valid, we should be using the accounts storage interface to check the username and password. The input for the username and password should be from the user as well. I think the checking of usernames and password should be a method that the user interface calls.

Furthermore, InputMismatchException appears to only be thrown by a Scanner. In this case, I can't see where the Scanner is being used.

In the LoginPage method, secondChoice, we should not be using system.out or system.in.

In the file LoginUseCase, I don't think we need an array list of all users. Our Storage methods don't have any method which can give all users. Instead, what we should do is use the account storage interface to check if a username and password are valid and then we can get the user data from the user storage interface. We should similarly do the same for creating a new user.

I did it!