CSC207-2022F-UofT / course-project-monopolymen

Java Swing full recreation of Monopoly in the Clean Architecture
5 stars 3 forks source link

Property Tile and TilePassResultModel Code review #35

Closed iamyanbo closed 1 year ago

iamyanbo commented 1 year ago

Needs more documentation on the difference between the two constructors in Property as currently it is difficult to distinguish between its use cases. TilePassResultModel needs comments to identify the case when the player lands on the tile and how the player is affected. There is documentation in the Tiles class with it being the default model (false, ""), but there should be a reference in TilePassResultModel addressing the case or explicitly stating that either the "passing" or "action" method will handle the logic