CSC207-2022F-UofT / course-project-monopolymen

Java Swing full recreation of Monopoly in the Clean Architecture
5 stars 3 forks source link

Player Code Review #36

Closed TahirLeonenko closed 1 year ago

TahirLeonenko commented 1 year ago

In a method called getGetOutOfJailCard was made, but since the logic is using “this.getOutOfJailFree != 0”, it returns false if they do have the card and true if they don’t. In a method called setLastRoll, the index of 1 is skipped and it instead uses 2. The enterJail method needs a Board parameter for the getJailTilePosition, also the method tries to use a non-static method in a static way. In update position it might be better to use the size of getTilesList instead of using the known size of the board.