CSC207-UofT / course-project-group-039-foodies

course-project-group-039-foodies created by GitHub Classroom
4 stars 0 forks source link

Refactor the code to remove clean architecture violations, namely the ones stated in the design document. #53

Open Supermac30 opened 2 years ago

Supermac30 commented 2 years ago

The main two violations are that

Supermac30 commented 2 years ago

As stated in the design document: "[...] there are some violations where entities are accessed directly from the controller and gateway layer in our code left to fix. Namely, the PreferenceBookCSVReader gateway uses the constructor for a PreferenceBook, which we can fix by creating a PreferenceBookFactory, and the RateRecipeCommand controller calls the getUsername getter method in the User entity, which we can fix by creating a new UseCase class with this responsibility."

Supermac30 commented 2 years ago

Other identified violations include the constructor for the RecipeCollection, an entity, being called in the RecipeCSVReader class, a gateway.