search

CSC495-2014 / TeamworkEnglewoodGit

GNU General Public License v2.0
5 stars 15 forks source link

Empty Commit Messages #111

Closed ZAM- closed 10 years ago

ZAM- commented 10 years ago

At what level do we plan on enforcing non-empty commit messages? I can create a check on the file system side and set a general commit message such as "Changes have been made". I do however believe we should have something on the client side to check wether or not there is a commit message.

It is possible that someone has already done this, but I'm not sure if it was brought up before.

mikeholler commented 10 years ago

@samuelfrench should check whether the commit message is empty before doing anything, and return a 400 if it is. This will allow me to catch the error on the client when I make the request.

ZAM- commented 10 years ago

Awesome, I'm glad we got that figured out. I'll be closing this now.

mikeholler commented 10 years ago

Let's leave it open for @samuelfrench, actually.

samuelfrench commented 10 years ago

Ok, I can get this done today. @apotheos My code is all written, I need to do some testing tonight, and I'm at work now, so I'll get the pull request in ASAP.

mikeholler commented 10 years ago

Excellent, thanks sam!

samuelfrench commented 10 years ago

@apotheos Hey Mike,

I have about 20 minutes max of work to do when I get out of class at 8:30, then I planned to write some phpunit tests to just at least make sure the functions where I don't need to access the Input object are functioning correctly and giving the response expected. Not sure how long that will take.

Just so you know my timeline of getting this pull request in.

samuelfrench commented 10 years ago

@ZAM- @apotheos I believe this is fixed with 122-125 of https://github.com/CSC495-2014/TeamworkEnglewoodGit/blob/master/app/controllers/GitController.php#L123

Please close this unless I have made an oversight.

mikeholler commented 10 years ago

Thanks Sam!