Testing - ida vs id

[cdwainscott]

@kjmcmahon and I found the problem that in gitcontoller.php on line 38 it says:

$this->wrapper->setPrivateKey('../data/' . 'users/' . $userName . '/id_rsa');

the rest of the code needs to be corrected from "/ida_rsa' to '/id_rsa' to be consistent with this call .

[mikeholler]

This is incorrect. Everything should be changed to id_rsa, as that is the correct and standard name for SSH keys like this. @ZAM- and @wwforg, since you two are the ones that use this file I'm assigning you to this issue.

[mikeholler]

I fixed it myself, as it was just a simple find and replace and I had to fix the thing with base_path() anyway.

[kjmcmahon]

there is still an "ida_rsa" somewhere the custom git command code, specifically in the path looking for the private key

[mikeholler]

I can't find it in my code, so "somewhere" doesn't help. Can you find the line on upstream/master and tell me the exact line number?

[kjmcmahon]

I have had no part in the development of this code so I have no idea where it might be or whose code the error is in. When I try running a custom git command, git status for this case the result is :

{"error":{"type":"GitWrapper\GitException","message":"Path private key could not be resolved: ..\/data\/users\/kjmcmahon\/ida_rsa","file":"\/home\/ken\/lampstack\/frameworks\/laravel\/vendor\/cpliakas\/git-wrapper\/src\/GitWrapper\/GitWrapper.php","line":286}}

[kjmcmahon]

maybe in the GitWrapper line 286?

[mikeholler]

I see. I did a search for all instances of ida_rsa in the project and came up with nothing. Are you sure you're using the changes I pushed to upstream/master? Try a git pull upstream master and let me know if the problem is still there.

[kjmcmahon]

yeah its gone now, thanks

[mikeholler]

No problem, just make sure you are always testing the most recent version of the code.