search

CSC495-2014 / TeamworkEnglewoodGit

GNU General Public License v2.0
5 stars 15 forks source link

fixed fn call #158

Closed samuelfrench closed 10 years ago

samuelfrench commented 10 years ago

@apotheos

In reply to the last pull, no I didn't have time to run it since Friday when I tested my previous version. I will have time later tonight to do it.

mikeholler commented 10 years ago

In the future please do not submit code unless you have run it. Otherwise we risk errors getting into upstream/master that could have very easily been avoided. I do not have the time to test everyone's code manually when accepting their merge requests, and I assume everyone has done their to make sure their code works.

samuelfrench commented 10 years ago

@apotheos

No I feel you. I did test everything Friday night and I got confused with what version I was running considering these changes were located in the testing branch and I was testing master. My bad. I'm talking to David to work out getting PHP unit tests done to ensure everything is flawless at this point considering this part is pretty much completed.