search

CSC495-2014 / TeamworkEnglewoodGit

GNU General Public License v2.0
5 stars 15 forks source link

Authentication and Authorization #165

Closed wwforg closed 10 years ago

wwforg commented 10 years ago

@Apotheos I have not implemented the rework that you and I were discussing. I have been working on it but have run into a whole host of issues while debugging. I will be continuing to work on it so that we can add it in later, but for this deadline Prof. St. Clair approved my just turning in the working files. The other things that have been added since the last pull request include filtering and logging out. If you type in a URL to go to a user's projects page, or an editor page, it will check the username in the URL vs the logged in user. If it does not match up, it will redirect to the projects page of the logged in user. If no one is logged in, then it will redirect to the login page. It is quite a simple matter to add any additional filters, but I believe these are the only necessary ones. @ydeleon6 please sign off.

ydeleon6 commented 10 years ago

I've been in the lab with Will and I've been looking over the code as it gets completed as well as tested it on my computer. This works, I'm signing off on it.

mikeholler commented 10 years ago

Awesome @wwforg, I'm going to merge it now but you also have the SSH key stuff working, yes?

mikeholler commented 10 years ago

Looking good @wwforg! Although the refactoring would be welcome after the project is over, if that is something you're willing to do, I am very happy that we have this working. I am beginning the process of merging your PR, but it will be a few before I do because you committed a few files you shouldn't have. I'll fix them though, don't worry :smile:

wwforg commented 10 years ago

The ssh key stuff is working, or at least my side of it is with the posting of the public key. I would definitely be happy to complete the refactoring after a bit of a break from this term. For that, would it be possible for me to retain access to the server for testing? I also want to add in the possibility of an 'admin' account like demond was talking about, but I didn't get a chance to add that in to the filters for this pull request. I was also going to look at expanding the filters a bit more to make things more secure

mikeholler commented 10 years ago

@wwforg, of course you can use that server for testing still. It's free for me on Amazon AWS for about 6 more months. Of course, I may decide to take it down temporarily if I want to fire up another server to play with (can't have two on at the same time without paying for one), but I don't see myself doing that for a while.

mikeholler commented 10 years ago

Oh, I'll also be taking a break from working on this like you, but I fully intend to support Teamwork Englewood on this project if they have any major problems or want small feature adds here and there. Thanks for offering to help!

mikeholler commented 10 years ago

Oh, hey, I forgot to ask. Did you have any documentation you wanted to add?

wwforg commented 10 years ago

Crap I did forget that. I'm wiped out right now but I'll write up some documentation by class tomorrow

mikeholler commented 10 years ago

Thanks :) I have an INSTALLATION.md file in the base of the respository. Feel free to add to that what is needed for installation and pull request it when you're done. Please put every other form of documentation in the wiki.