CSC495-2014 / TeamworkEnglewoodGit

GNU General Public License v2.0
5 stars 15 forks source link

Superuser and Login Fix #176

Closed wwforg closed 10 years ago

wwforg commented 10 years ago

Changes in this pull request are as follows:

There is now a superuser variable in the oauth config file. The username entered here will be able to go to any user's project page and view their individual projects. The only limitation to this that I can think of is that the superuser should probably manually type in to go to any individual project, as if he clicks on the project it might either clone to his or clone to the user's directory without the user's permission, I don't know how that is handled on the backend, but either way, it doesn't sound desirable, what do you think @apotheos?

I have made a couple quick changes to how the user is processed. In the even of an invalid email it will redirect to a quick little error page (quick as in it is just text and a link back, nothing even remotely close to fancy) advising to refer to the documentation on how to set that up.

The restructuring is still in the works, but like I said I didn't have time to finish that.

mikeholler commented 10 years ago

If the admin clicks on a link in his/her own project's page, it will go to their instance of it, and shouldn't be a problem in the slightest. In fact, I believe currently logged in user is taken from the URL everywhere except your route filter, not the session, although I could be wrong. I'm merging this in, although I haven't exactly had time to vet it out. The files changed look reasonable and I trust that it works. Thanks Will!