search

CSC510-2015-Axitron / maze

Main repo for maze game
0 stars 2 forks source link

Move core functions from mazeMenu.js to maze.js #63

Closed macluo closed 9 years ago

macluo commented 9 years ago

As you guys may have noticed the test case is broken with mazeMenu.js after jQuery UI code is in place. To fix the problem, the test case has to include jQuery UI mocks object. Instead of going this route, I propose dividing mazeMenu.js and move those functions not related to menu to maze.js. Basically all the code before line 761 should go replacing maze.js, which is not currently being used. Maze will still run, but the test case will have to be separated as well but we can decide if we want both files tested or not. Any comment or feedback about this idea?

macluo commented 9 years ago

Just added minimal code to make jQuery UI stuff pass the test 0ac9440e12c59543b2959387e88fe8cdff2cc6d2. Branch coverage is currently low but I will leave it for now due to time constraint. Anyone interested may go ahead and feel free to move code from mazeMenu.js to maze.js .

macluo commented 9 years ago

I will close this for now.