Closed etracey7 closed 2 years ago
coveralls
commented
2 years ago | Totals | |
|---|---|
| Change from base Build 1424288931: | 0.0% |
| Covered Lines: | 188 |
| Relevant Lines: | 219 |
snapcat
commented
2 years ago Discussion:
jhnguye4 — 11/02/2021 I wrote up a documentation of what we improved for this round. let me know if i missed something or if i need to remove anything
shramish — 11/03/2021 What was the coverage for the previous team? I was thinking we could add something like increased coverage from 25% to 75% in the project 1 vs project 2 document
Leila Moran — 11/03/2021 Coverage was 32%, but when we introduced login/signup/etc, it dropped to 23%.
Leila Moran — 11/03/2021 Let's add netlify to the list of updates.
Leila Moran — 11/03/2021 New branch: group25-documentation for... documentation. And updating the rubric.
EmilyTracey — 11/03/2021 I am working on getting improvements in markdown right now! I added the netlify stuff
Leila Moran — 11/03/2021 @ EmilyTracey Can I merge the documentation branch with yours, or would you rather leave it?
EmilyTracey — 11/03/2021 go ahead and merge! I didn't know how to add it to yours so I created a new one, but we really only need one
Leila Moran — 11/03/2021 Also, can you change your PR to a draft? There are some little things that need to be edited before it should be pushed.
EmilyTracey — 11/03/2021 sorry just changed it... i think
Leila Moran — 11/03/2021 What's the netlify project ID? We can use it to add a status badge.
EmilyTracey — 11/03/2021 The only thing I found was an API ID: ***** is this what you need?
Leila Moran — 11/03/2021 Yup, that's it! Thanks
shramish — 11/03/2021 https://github.com/CSC510-Group-25/feature-hunt/pull/127 PR for Project2rubric
Peeyush — 11/04/2021 I am closing out all the Bump PRs
Leila Moran — 11/04/2021 Ah, btw, the rubric needs to be updated? And the improvements too. There needs to be a note on heroku and a screenshot for adding projects should also be added.
Peeyush — 11/04/2021 I will add the steps for heroku deplyment The coverage badge is showing 25% test coverage ? Is it because its cached ?
Leila Moran — 11/04/2021 Which branch are you on?
Peeyush — 11/04/2021 main
Leila Moran — 11/04/2021 It's showing 73% for me. Btw, make the changes to improvements here:
https://github.com/CSC510-Group-25/feature-hunt/tree/group25-improvements
Peeyush — 11/04/2021 yeah weird when I open it in incognito it shows 73, its cached for me
✔️ Deploy Preview for feature-hunt-25 ready!
🔨 Explore the source changes: 662760300ef418d8a40a874be30ba6610a4a1e9f
🔍 Inspect the deploy log: https://app.netlify.com/sites/feature-hunt-25/deploys/6184aaeb3acb4f0007edaf2c
😎 Browse the preview: https://deploy-preview-134--feature-hunt-25.netlify.app