Closed jhnguye4 closed 2 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/Components/ProjectForm.js | 23 | 28 | 82.14% | ||
<!-- | Total: | 23 | 28 | 82.14% | --> |
Totals | |
---|---|
Change from base Build 1418772856: | 0.5% |
Covered Lines: | 184 |
Relevant Lines: | 215 |
Discussion(s):
jhnguye4 — 10/23/2021 i have created a project submittal form its on group25-submit-project branch
Leila Moran — 10/23/2021 Just assigned you to the relevant issue
jhnguye4 — 10/23/2021 thanks, but is there multiple issues for this now? because i thought peeyush assigned me it yesterday
Leila Moran — 10/23/2021 Uh... could be? https://github.com/CSC510-Group-25/feature-hunt/issues/17
Leila Moran — 11/02/2021 @ jhnguye4 Do you want to try your hand at improving the pylint scores? jhnguye4 — 11/02/2021 im working right now on trying to get the backend to work with project submittal form right now if i have time i will try
Leila Moran — 11/04/2021 Added Codacy analysis for good measure, updated README, and did things to the wiki to make MongoDB setup less of a headache.
Leila Moran — 11/04/2021 Working on a test suite for ProjectForm.js right now. I'll also fix the broken header tests.
Leila Moran — 11/04/2021 Also, there's a potential issue: projects need to have at least one feature so that Feature.js, ProductTile.js, and Product.js don't break and scream about missing indices. To prevent this, a default feature should be added.
jhnguye4 — 11/04/2021 peeyush has added that when a project is submitted now
Leila Moran — 11/04/2021 It's handled by the backend?
jhnguye4 — 11/04/2021 yea its handled where the api is called [2:37 AM] also tests are failing for the PR could you help with that?
Leila Moran — 11/04/2021 Yup, working on it right now
jhnguye4 — 11/04/2021 thanks
Leila Moran — 11/04/2021 Quick question: are you changing the labels on input, or are you changing the values?
jhnguye4 — 11/04/2021 I think we are setting a standard feature when any project is submitted
Leila Moran — 11/04/2021 Upvoting is broken on newly added projects. They need to be pushed to the db with a vote count of 1.
jhnguye4 — 11/04/2021 Alright, I'll get to that tomorrow then. Thanks for pointing it out
Leila Moran — 11/04/2021 Also, the submitted project isn't added to the list of dashboard projects.
I'm done with the tests. Goodnight!
Leila Moran — 11/04/2021 @ jhnguye4 I think your branch is ready.
https://github.com/CSC510-Group-25/feature-hunt/pull/166
Approve whenever!
✔️ Deploy Preview for feature-hunt-25 ready!
🔨 Explore the source changes: 34db4c0bda37b0d547e1085306aa0f9553ffe845
🔍 Inspect the deploy log: https://app.netlify.com/sites/feature-hunt-25/deploys/61840ac6c370d0000715b653
😎 Browse the preview: https://deploy-preview-148--feature-hunt-25.netlify.app