Closed snapcat closed 2 years ago
coveralls
commented
2 years ago | Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/Components/Dashboard.js | 1 | 48.48% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 1415103426: | 47.2% |
| Covered Lines: | 162 |
| Relevant Lines: | 188 |
netlify[bot]
commented
2 years ago ✔️ Deploy Preview for feature-hunt-25 ready!
🔨 Explore the source changes: af9cb74f370332dd85ae5c5829563b144dfe6f6c
🔍 Inspect the deploy log: https://app.netlify.com/sites/feature-hunt-25/deploys/618200062a7dc70008e55766
😎 Browse the preview: https://deploy-preview-92--feature-hunt-25.netlify.app
snapcat
commented
2 years ago Discussion
EmilyTracey — 10/30/2021 I think I have sign up and login working. They still need some tests written for them, but I am going to move on to getting the user dashboard/projects/features working and then circle back to testing at the end
Leila Moran — 10/30/2021 I'll get started on testing in the meantime.
shramish — 10/30/2021 I can write the tests for these
Leila Moran — 10/30/2021 If we don't care about branching lines of code, our current coverage is 65%. If we DO care about branching, then our coverage is 52%. Not bad at all, I think. :D
EmilyTracey — 10/30/2021 thats so much better!
Leila Moran — 10/30/2021 I'll turn branching back on for now. It's a huge step up from the original 32%.
Leila Moran — 11/02/2021 @ everyone Since it's nearly impossible to test Service.js, should it be removed from the list of files to cover? Peeyush — 11/02/2021 Yup EmilyTracey — 11/02/2021 Yes
Leila Moran — 11/02/2021 https://github.com/CSC510-Group-25/feature-hunt/pull/92
It bumps code coverage up from 25% to 72%, which is a massive improvement.
DM:
shramish — 10/30/2021 I am planning on adding test cases for frontend. I wanted to check with you if you have done something in this already
Leila Moran — 10/30/2021 Yup! You can see here:
https://github.com/CSC510-Group-25/feature-hunt/pull/92
It's a draft PR just so it's easy to see coverage updates.
So far, I've done Product.js and ProductTile.js.
Right now, I'm working on Feature.js.
shramish — 10/30/2021 I think that leaves dashboard, what else? Service?
Leila Moran — 10/30/2021 It would be great if you could figure out why some tests in ProductTile.tests.js aren't working. They're up on the issues page.
If you go to the group25-api-connect branch, you'll see Login and SignUp. Also, Header hasn't been fully covered.
shramish — 10/30/2021 Okay, so I'll do dashboard, productTile, Login, signup and header?
Leila Moran — 10/30/2021 ProductTile is more or less done, I think. It's just those two tests that need debugging. They pass just to get coveralls working, but they're don't actually update any values. [3:28 PM] Ah! Also, there's a problem in Product.tests.js. It's "test sort by". I couldn't figure out how to check if the text was actually highlighted or not.
Leila Moran — 10/30/2021 Btw, I just pushed test file templates. They're under the / tests folder.
I wrote down the testIDs to make testing easier.shramish started a call that lasted 7 minutes. — 11/02/2021 (Discussed SignUp, Login, Header tests)
shramish — 11/02/2021 can I check on coveralls if my test is improving coverage without pushing to github?
Leila Moran — 11/02/2021 Sure! You don't need coveralls exactly. Just open an IDE terminal and type 'npm run coverage'
shramish — 11/02/2021 awesome! thanks
shramish — 11/02/2021 how would you suggest I test this "ReactSession.set("username", email);" , line 49 in login.js?
Leila Moran — 11/02/2021 Unfortunately, it's extremely difficult with jest and react's testing library. It's honestly not worth the effort, I think. Plus, there's no need to unit test when you can manually test by clicking around, right? :D
shramish — 11/02/2021 In that case Login is done, I think
snapcat
commented
2 years ago DM:
shramish — 10/30/2021 I am planning on adding test cases for frontend. I wanted to check with you if you have done something in this already
Leila Moran — 10/30/2021 Yup! You can see here:
https://github.com/CSC510-Group-25/feature-hunt/pull/92
It's a draft PR just so it's easy to see coverage updates.
So far, I've done Product.js and ProductTile.js.
Right now, I'm working on Feature.js.
shramish — 10/30/2021 I think that leaves dashboard, what else? Service?
Leila Moran — 10/30/2021 It would be great if you could figure out why some tests in ProductTile.tests.js aren't working. They're up on the issues page.
If you go to the group25-api-connect branch, you'll see Login and SignUp. Also, Header hasn't been fully covered.
shramish — 10/30/2021 Okay, so I'll do dashboard, productTile, Login, signup and header?
Leila Moran — 10/30/2021 ProductTile is more or less done, I think. It's just those two tests that need debugging. They pass just to get coveralls working, but they're don't actually update any values. [3:28 PM] Ah! Also, there's a problem in Product.tests.js. It's "test sort by". I couldn't figure out how to check if the text was actually highlighted or not.
Leila Moran — 10/30/2021 Btw, I just pushed test file templates. They're under the / tests folder.
I wrote down the testIDs to make testing easier.shramish started a call that lasted 7 minutes. — 11/02/2021 (Discussed SignUp, Login, Header tests)
shramish — 11/02/2021 can I check on coveralls if my test is improving coverage without pushing to github?
Leila Moran — 11/02/2021 Sure! You don't need coveralls exactly. Just open an IDE terminal and type 'npm run coverage'
shramish — 11/02/2021 awesome! thanks
shramish — 11/02/2021 how would you suggest I test this "ReactSession.set("username", email);" , line 49 in login.js?
Leila Moran — 11/02/2021 Unfortunately, it's extremely difficult with jest and react's testing library. It's honestly not worth the effort, I think. Plus, there's no need to unit test when you can manually test by clicking around, right? :D
shramish — 11/02/2021 In that case Login is done, I think
Resolves #80, resolves #96, resolves #70, resolves #71, resolves #72, resolves #73, resolves #74, resolves #77, resolves #2, resolves #97, resolves #98,