Linkify misses extensions off URLs

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. type http://example.com/somefile.jpg into a SIAB session
2. notice that only "http://example.com/somefile" is linkified

What is the expected output? What do you see instead?

To linkify the extension too

What version of the product are you using? On what operating system?

Debian lenny, amd64, SVN r142, Firefox 3.0.11 on Ubuntu, and also IE8 on Win XP

Please provide any additional information below.

Screenshot attached

Original issue reported on code.google.com by gnute...@gmail.com on 8 Jul 2009 at 11:20

GoogleCodeExporter commented 9 years ago

wrong button, submitted without attachment.  Attached:

Original comment by gnute...@gmail.com on 8 Jul 2009 at 11:21

Attachments:

siab.png

GoogleCodeExporter commented 9 years ago

Ah, good catch. I am trying to carefully balance the set of allowed characters 
that
make up a URL, with the possible set of characters that could directly follow a 
URL
when printed as part of English text. Obviously, this is not an exact science, 
and
mismatches are possible, because we just don't have enough context to always 
detect
the URL correctly. But you are correct and we should make sure that common 
patterns
are detected correctly. I tuned this code a little more and the version in SVN 
should
now handle file extensions properly.

Original comment by zod...@gmail.com on 8 Jul 2009 at 5:24

Changed state: Fixed

CSCG / shellinabox

Linkify misses extensions off URLs #21