Exclamation mark does not work with french keyboard layout

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Configure a French keyboard (AZERTY) layout in the OS
2. Type "!" in a ShellInABox console (key next to the right shift key)

What is the expected output? What do you see instead?
Exclamation mark should appear on the command line. Nothing actually appears.
Quite annoying for VI...

What version of the product are you using? On what operating system?
Version 2.10, or demo on ShellInABox homepage

Please provide any additional information below.
The exclamation mark (keycode 223) seems to be treated as a control character, 
which it is not.
The problem does not appear with a QWERTY keyboard layout because "!" is the 
secondary symbol on the "1" key, which is recognized correctly.

Original issue reported on code.google.com by lot...@gmail.com on 3 Aug 2010 at 4:19

[GoogleCodeExporter]

Quick fix : accept keycode 223 as a normal key.

Original comment by lot...@gmail.com on 4 Aug 2010 at 9:33

Attachments:

• keycode223.diff

[GoogleCodeExporter]

Do you need anything else to apply the fix ?

Original comment by lot...@gmail.com on 19 Aug 2010 at 10:04

[GoogleCodeExporter]

Thank you very much for a) your excellent analysis, b) writing an actual patch, 
and c) pinging me when I didn't reply in time.

I was too busy with other work and never even noticed that you had provided a 
patch. As fixing keyboard layout problems is difficult without having access to 
a French keyboard and without understanding how the keyboard is supposed to 
behave, I often treat these bugs as lower priority.

But none of that excuses me ignoring your patch. That's actually extremely 
helpful and is the best type of bugreport that I can hope for!

Original comment by zod...@gmail.com on 19 Aug 2010 at 7:13

• Changed state: Fixed

[GoogleCodeExporter]

Thanks a lot for this patch.

For any reason i had no problem with my home keyboard when i installed and 
tested shellinabox and then get stuck with "login failed" error with a 
different keyboard because i have a ! (exclamation character) in my password.
Both keyboard are "azerty"...

Hopefully the patch is to be applied on the js file so i could access it 
client-side first to be able to login, and then i changed it server side to 
correct it definitely.

Thanks again and maybe this 2010 patch should be applyed on to the ubuntu 
binary i downloaded yesterday.

Original comment by joachim...@gmail.com on 19 Dec 2012 at 11:39