search

CSCI-GA-2820-SU23-001 / shopcarts

NYU DevOps Shopcarts Service Summer 2023
Apache License 2.0
4 stars 4 forks source link

Delete Old APIs and Recover Coverage #156

Closed LillisLuo closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +20.23% :tada:

Comparison is base (7650c10) 78.18% compared to head (0513560) 98.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #156 +/- ## =========================================== + Coverage 78.18% 98.41% +20.23% =========================================== Files 8 8 Lines 573 443 -130 =========================================== - Hits 448 436 -12 + Misses 125 7 -118 ``` | [Files Changed](https://app.codecov.io/gh/CSCI-GA-2820-SU23-001/shopcarts/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CSCI-GA-2820-SU23-001) | Coverage Δ | | |---|---|---| | [service/common/error\_handlers.py](https://app.codecov.io/gh/CSCI-GA-2820-SU23-001/shopcarts/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CSCI-GA-2820-SU23-001#diff-c2VydmljZS9jb21tb24vZXJyb3JfaGFuZGxlcnMucHk=) | `83.33% <ø> (+15.47%)` | :arrow_up: | | [service/routes.py](https://app.codecov.io/gh/CSCI-GA-2820-SU23-001/shopcarts/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CSCI-GA-2820-SU23-001#diff-c2VydmljZS9yb3V0ZXMucHk=) | `100.00% <100.00%> (+32.18%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wl2484 commented 1 year ago

should we also recover the minimum-coverage=95 setting in setup.cfg ?