#7 Create database model for promotions

CSCI-GA-2820-SU24-001 / promotions

NYU DevOps Promotions Service Summer 2024

Apache License 2.0

0 stars 0 forks source link

#7 Create database model for promotions #10

Closed mingyi850 closed 3 days ago

mingyi850 commented 5 days ago

Create Promotions model based on spec
Create Tests for Create Promotions
Create Promotion Factory
Expose Postgres ports outside devcontainer

ChungLinWu0829 commented 4 days ago

LGTM. But I would like to know if we need more test cases, or if it is sufficient to meet the requirement now.

mingyi850 commented 3 days ago

@ChungLinWu0829 Imo it should be okay for now, we have other stores for create, delete, update etc... and tests should be added for each of those features too! I added tests for create for this story to

Prove that the model is viable and 'create-able' in the database
Provide an example of how the object should be instantiated (in model-test)

Lmk if you have other issues, or else i think i'll merge it to unblock the rest of the stories :)