Closed Charlie-XIAO closed 1 month ago
Deskulpt binaries have been built successfully on all supported platforms. Your pull request is in excellent shape! You may check the built Deskulpt binaries here and download them to test locally.
Workflow file: .github/workflows/build.yaml
. Generated for commit: 00632a4
.
Because my disk is going to explode... Also there will be nicer diff for the lock file since it's yaml instead of json.
And I heard that
pnpm
has nice features for monorepos which is our case (core and several tooling packages), though I haven't explored much yet, except that nowpnpm install
at the project root will recursively install all dependencies for the workspaces due to thepnpm-workspace.yaml
configuration which is quite nice already.There are many things to look into for our monorepo layout, e.g. I'm planning to refactor the scripts in
package.json
and maybe use some tool liketurborepo
to ensure same versions of dependencies, make better pipelining both for building and publishing, etc. But those are future work.