ENH support absolute path imports

CSCI-SHU-410-SE-Project / Deskulpt

Deskulpt (Desktop + Sculpt, pronounced /'deskʌlpt/), a cross-platform desktop customization tool.

https://csci-shu-410-se-project.github.io/Deskulpt/

MIT License

2 stars 0 forks source link

ENH support absolute path imports #216

Closed Charlie-XIAO closed 2 months ago

Charlie-XIAO commented 2 months ago

This is part of #66, where we used the absolute path to point to the external dependencies bundle.

github-actions[bot] commented 2 months ago

✔️ Deskulpt Built Successfully!

Deskulpt binaries have been built successfully on all supported platforms. Your pull request is in excellent shape! You may check the built Deskulpt binaries here and download them to test locally.

_{Workflow file: .github/workflows/build.yaml. Generated for commit: ab94dd7.}

Charlie-XIAO commented 2 months ago

On second thoughts, if there is ever a workaround not to use the absolute file in #66, we should close this one. It is not reasonable to use absolute path imports in widgets; after all the imports cannot go beyond the root thus can always be substituted with relative imports...

Charlie-XIAO commented 2 months ago

I'm going to close this one. There is a way to accomplish #66 without having to support absolute paths.