CSCI-SHU-410-SE-Project / Deskulpt

Deskulpt (Desktop + Sculpt, pronounced /'deskʌlpt/), a cross-platform desktop customization tool.
https://csci-shu-410-se-project.github.io/Deskulpt/
MIT License
2 stars 0 forks source link

FIX symlink issue when resolving relative path imports in the bundler #221

Closed Charlie-XIAO closed 2 months ago

Charlie-XIAO commented 2 months ago

This PR fixes the issue seen in this macOS test workflow run, due to symlinks /var to /private/var on macOS.

We should be consistent with how the SWC bundler deals with paths, otherwise we cannot compare with the resolved paths via prefix. See these lines in SWC bundler source code, we should canonicalize only on Windows.

github-actions[bot] commented 2 months ago

✔️ Deskulpt Built Successfully!

Deskulpt binaries have been built successfully on all supported platforms. Your pull request is in excellent shape! You may check the built Deskulpt binaries here and download them to test locally.

Workflow file: .github/workflows/build.yaml. Generated for commit: 2c7ceac.