Added an introductory video to the page

CSCfi / csc-user-guide

User guides, FAQs and tutorials related to CSC services

https://docs.csc.fi

Creative Commons Attribution 4.0 International

47 stars 83 forks source link

Added an introductory video to the page #2008

Closed mkannisto closed 7 months ago

mkannisto commented 7 months ago

Proposed changes

I added the embedded introductory video to the new SD Connect.

Link to the preview page: https://csc-guide-preview.rahtiapp.fi/origin/SD-Connect-Beta-video/data/sensitive-data/sd-connect-beta/

Checklist before requesting a review

[X] I have followed the instructions in the Contributing and Styleguide documents.
[X] My pull request passes all tests.
[X] I have included a link to the appropriate preview page (select your branch from the list).

rkronberg commented 7 months ago

Hi @mkannisto ! The tests are failing because there's some issues with how the video has been embedded. See https://github.com/CSCfi/csc-user-guide/blob/master/FAQ.md#how-to-embed-an-external-video (notably use of src instead of srcdoc)

joonas-somero commented 7 months ago

Yes, the "incorrect" attribute name src was introduced when the url was fixed. If it seems ridiculous to go through all of this just to add a simple video, it's because it absolutely is! The current mechanism is a relic from earlier and I'm working on a fix.

joonas-somero commented 7 months ago

There we go! Now if we could just get someone to sign off on this... :grin:

fmorelloCSC commented 7 months ago

Sorry I received several notifications so lost track of it, now approved

joonas-somero commented 7 months ago

Sorry I received several notifications so lost track of it, now approved

Oh no I didn't mean to criticize. I just start to make jokes like that when I'm in a good mood. :slightly_smiling_face: Have a nice weekend!