search

CSCfi / metadata-submitter

Metadata Submission Interface for SDA
https://metadata-submitter.rtfd.io
MIT License
3 stars 2 forks source link

`resource_id` and `catalogue_item_id` don't belong in `submission.json` #649

Open csc-felipe opened 1 year ago

csc-felipe commented 1 year ago

Describe the bug

These lines don't belong in the submission schema. They should belong to a dataset object. https://github.com/CSCfi/metadata-submitter/blob/0f11942771a3a6899984101bd12039b01b4690b0/metadata_backend/helpers/schemas/submission.json#L1190-L1197

They should be safe to remove, as no code adds those to a submission. It is instead added to datasets in the publication phase. https://github.com/CSCfi/metadata-submitter/blob/0f11942771a3a6899984101bd12039b01b4690b0/metadata_backend/api/handlers/publish.py#L423-L435

Additional context

Thanks to @blankdots for figuring out the issue in the discussion in #648

csc-jm commented 1 year ago

So should that dac (now renamed to rems) field and its properties be added to both EGA and BP json schemas?

csc-felipe commented 1 year ago

I don't think those should be changed. Does @blankdots have an opinion?

One possible solution would be to put it in the submission's metadataObject field

blankdots commented 1 year ago

One possible solution would be to put it in the submission's metadataObject field

I was thinking more in extraInfo > datasetIdentifiers as it is related to dataset the rems workflow, resource and catalogue item, however metadataObject works as well