Multiple resources with different licenses in UI

CSCfi / rems

Resource Entitlement Management System is a tool for managing access rights to resources, such as research datasets.

MIT License

51 stars 22 forks source link

Multiple resources with different licenses in UI #1999

Closed jaakkocsc closed 3 years ago

jaakkocsc commented 4 years ago

As an owner, when I go to the create catalogue item page,

if same resource exists with different licenses the UI does not distinguish them, i.e. it's impossible to know which resource to select.

marharyta commented 3 years ago

Can you maybe give a screenshot @jaakkocsc ?

Macroz commented 3 years ago

It's the create catalogue item page resource dropdown that displays just the name of the item?

marharyta commented 3 years ago

It doesn't look like the type of licence is currently exposed in the re-frame db

marharyta commented 3 years ago

I think the easiest would be to get licence from the queries.sql the licence and expose it into the catalogue get-catalogue-items, what do you think @Macroz @opqdonut

Macroz commented 3 years ago

I think the easiest would be to get licence from the queries.sql the licence and expose it into the catalogue get-catalogue-items, what do you think @Macroz @opqdonut

I think the resources are fetched from the database and the licenses are joined to them in the service layer so they should be available already. You are looking at the wrong place (it's not the catalogue but the resources ...)

opqdonut commented 3 years ago

Perhaps this helps: create-catalogue-item

marharyta commented 3 years ago

Hmm, do we have the data model definition anywhere in the docs?

Macroz commented 3 years ago

You can have a look at it in

re-frisk like Joel showed or
from the https://rems-dev.rahtiapp.fi/swagger-ui/index.html#/resources/get_api_resources too.
Third place is of course the schema https://github.com/CSCfi/rems/blob/master/src/clj/rems/api/resources.clj#L12
The relevant code can also be seen elsewhere (the localized names of the licenses).

marharyta commented 3 years ago

Thanks a lot @Macroz

marharyta commented 3 years ago

I think my initial idea was pretty close, though. We do fetch catalogue items from resources and we do not expose licences in that call.

Macroz commented 3 years ago

I am confused at what you are saying, so are we talking about the same thing:

create catalogue item admin page
the select resource dropdown (these should show the license names)
resources are fetched from /api/resources which joins the licenses to every resource and contains the localized name too

opqdonut commented 3 years ago

The confusion was cleared up on flowdock. I also updated the ticket description to be a bit clearer!