ceciliatruong
commented
2 weeks ago - [ ] UI Bugs
- [x] Change font for reviewDetail page
- [x] comment gets cropped even when you expand the post (check the pho one)
- [x] Set up profile page link as the nav bar profile icon
- [x] Input fields in editprofile get pushed up when there's an error message, that should not happen
- [ ] Currently displaying no errors for when the user fails to upload a profile picture
- [x] users should be able to navigate from review detail to userpage or mypage
- [x] deleting a post doesn't clear out the post in the ui
- [ ] Logic Bugs
- [x] editprofile doesn't check validity of email
- you should check that it has at least the @ whatever . whatever structure
- [x] editprofile helper texts that show the user what their current info values are should only update if they successfully save... right now it's automatically displaying whatever the user is inputting (bc we're probably using the form's state variables, should NOT do that...it should be displaying the database's user info)
- [x] can't update user profile pics yet!!!
- [ ] Code Structure
- [x] move edmam app key & id into env file for security purposes lol.
- [x] change recipe of the week to an actually random recipe
- we can just do pasta of the week, just fetch the pasta query & randomly select from that array changing it every week
- [ ] move post functionality for editprofile into authprovider
- [ ] remove the unnecessary functions in editprofile
- instead of writing a whole new onChange function for picking up user input, you can just do (e) => setPassword(e.target.value)
- this only applies for the functions that are purely listening to user input, if there's any complex logic checks then this warrants an individual function
- [ ] change setState naming conventions in editprofile so that it's actually set[variable] & not confirm[variable]
- [x] migrate createUser functionality into authprovider
- [ ] clean out unnecessary comments and console logs