Closed sakeel-103 closed 2 weeks ago
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊
Sorry didn't understand Please PR #436 merge in your code that the changes will reflect in the design Please merge this PR not to add in your main.
On Mon, 10 Jun 2024, 9:49 pm CSEdge, @.***> wrote:
Merged #436 https://github.com/CSEdgeOfficial/learn.csedge.courses/pull/436 into main.
— Reply to this email directly, view it on GitHub https://github.com/CSEdgeOfficial/learn.csedge.courses/pull/436#event-13104331574, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAUBJUX3WKS3A4TGQ7477F3ZGXGXNAVCNFSM6AAAAABJBTH2ZCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGEYDIMZTGE2TONA . You are receiving this because you were assigned.Message ID: <CSEdgeOfficial/learn.csedge.courses/pull/436/issue_event/13104331574@ github.com>
My PR #436, you added to the main. Please remove it from there and merge the pull request
On Tue, 11 Jun 2024, 9:40 am Md Sakeel Ansari, < @.***> wrote:
Sorry didn't understand Please PR #436 merge in your code that the changes will reflect in the design Please merge this PR not to add in your main.
On Mon, 10 Jun 2024, 9:49 pm CSEdge, @.***> wrote:
Merged #436 https://github.com/CSEdgeOfficial/learn.csedge.courses/pull/436 into main.
— Reply to this email directly, view it on GitHub https://github.com/CSEdgeOfficial/learn.csedge.courses/pull/436#event-13104331574, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAUBJUX3WKS3A4TGQ7477F3ZGXGXNAVCNFSM6AAAAABJBTH2ZCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGEYDIMZTGE2TONA . You are receiving this because you were assigned.Message ID: <CSEdgeOfficial/learn.csedge.courses/pull/436/issue_event/13104331574@ github.com>
431
In Navbar section there was no hover effect. I add hover effect in existing html file. @CSEdgeOfficial Please merge this PR under gssoc'24 and level this PR.
Before Video -
https://github.com/CSEdgeOfficial/learn.csedge.courses/assets/136844498/b674e5dd-1105-4d5e-9937-1327cbfddcd8
After hover effect -
https://github.com/CSEdgeOfficial/learn.csedge.courses/assets/136844498/1a5a1095-5e5a-427f-9132-e16994cc2679
431
Description - In Navbar section there is no hover effect. Please assign me this task I'll add this effect with attractive color effect.
437
Footer section CSS style - Before -
https://github.com/CSEdgeOfficial/learn.csedge.courses/assets/136844498/f668721e-02cd-4088-bff1-c507fbbe59c4
After adding Social media -
https://github.com/CSEdgeOfficial/learn.csedge.courses/assets/136844498/3b0c9537-e60e-407a-ac06-b5886acebff7
437
I added CSS style in footer section as well as I add social media section with hover effect.
Type of PR
Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:
Additional context:
[Include any additional information or context that might be helpful for reviewers.]