Feature/initial value - Githubissues

CSFrequency / react-firebase-hooks

React Hooks for Firebase.

Apache License 2.0

3.58k stars 304 forks source link

Feature/initial value #270

Closed mauriceackel closed 1 year ago

mauriceackel commented 1 year ago

This is a PR related to #190 and #191.

It adds the possibility to define an initial value for the

useCollectionDataOnce
useCollectionData
useDocumentDataOnce
useDocumentData hooks.

It is heavily based on PR #191 but as this PR was merged to the 3.0.x branch, it is not part of the current version (i.e. 5.0.x).

I've slightly changed the code compared to #191 and I also fixed some typing issues.

@chrisbianca, please let me know if I could somehow help in making this part of version 5 swiftly.

Thanks, Maurice

mauriceackel commented 1 year ago

@dylanwatsonsoftware, I would love to to get your opinions on this, given that you created the original feature request an PR.

dylanwatsonsoftware commented 1 year ago

LGTM! ✅

The only thing that I can see missing compared to my original PR is the GitHub action. Though that is obviously unrelated to the actual feature, it does help prove that the code isn't totally broken 🤪

Thoughts @chrisbianca ?

mauriceackel commented 1 year ago

Hey @chrisbianca, did you have time to look into this by any chance? 🙂

chrisbianca commented 1 year ago

@mauriceackel This looks great, thanks for the submission and pulling through the functionality that was clearly missed when I did the last refactor. I'll get a release out in the coming days.