search

CSFrequency / react-firebase-hooks

React Hooks for Firebase.
Apache License 2.0
3.58k stars 304 forks source link

chore: add testing #274

Closed levino closed 1 year ago

levino commented 1 year ago

fix #99

levino commented 1 year ago

This will fix #99 I currently just have an issue using jsdom as the test environment, which I need to use @testing-library/react to start testing the hooks. I will continue the work on this and clean this PR up once that issue is resolved.

chrisbianca commented 1 year ago

@levino This is awesome, thank you! There's been another PR with a GitHub action to run a build, so will merge this and then look to combine them into a single action

levino commented 1 year ago

The action from #273 is already included. It is the "build" job. This step is quite unnecessary, since the actions/setup-node action already has caching included https://github.com/CSFrequency/react-firebase-hooks/blob/6b8d1051baa288be809b10937485417be6d13eff/.github/workflows/build.yml#L11-L22

The whole file can be deleted. If you prefer the other way to do the build, feel free to delete the "build" job from my actions file. I would at least consolidate both into one.