Remove duplication issue on adding child to RTDB

CSFrequency / react-firebase-hooks

React Hooks for Firebase.

Apache License 2.0

3.55k stars 304 forks source link

Remove duplication issue on adding child to RTDB #298

Open MB2M opened 1 year ago

MB2M commented 1 year ago

Listeners on "value" event were not remove on unmount + Unsubscribe functions were not called properly.

kutsan commented 1 year ago

I just tested this PR locally and it's working. Thanks!

revelcw commented 8 months ago

+1 This fixes the issue with React's StrictMode rerunning useEffects twice. lgtm

yamcodes commented 7 months ago

This needs to be merged. As things stand this library is unusable on an updated environment (React v18). Internally, we're forced to use a fork just to be able to use this library.