CSHS-CWRA / RavenHydroFramework

repository for the Raven Hydrological Modelling Framework developed at the University of Waterloo
Artistic License 2.0
22 stars 12 forks source link

Reservoir evaporation incorrectly reported as zero in ReservoirMassBalance.csv #21

Closed BernardoTeufel closed 9 months ago

BernardoTeufel commented 10 months ago

Setup Information

Description

For all reservoirs in the domain, the sub???????.evap..m3. columns in ReservoirMassBalance.csv are filled with zeros. However, evaporation is occurring, as evidenced by the sub???????.MB.error..m3. in the same file, which is strongly related to PET in the ForcingFunctions.csv file (relationship is not perfect given that the watershed-average PET is not equal to the PET for each HRU/lake).

Scatterplot of MB error vs PET, red line is theoretical relationship based on lake surface area: image

MB error over 20 days (mid-June to early July), red line is PET scaled by lake surface area: image

Edit: confirmed relationship to OW PET by setting :OW_Evaporation PET_CONSTANT, which results in constant MB errors for all reservoirs.

Steps To Reproduce

No response

Additional context

No response

Contribution

analytophile commented 9 months ago

could you verify this still occurs with the most recent version of the source code? I believe this was fixed after v3.6, and suggestions here should solely address the most recent release versions.

BernardoTeufel commented 9 months ago

Issue is still there in v3.7, but is fixed in the latest code from this repository