search

CSHS-CWRA / RavenHydroFramework

repository for the Raven Hydrological Modelling Framework developed at the University of Waterloo
Artistic License 2.0
22 stars 12 forks source link

Zero outflow of constituents from reservoirs #28

Closed BernardoTeufel closed 4 months ago

BernardoTeufel commented 7 months ago

Setup Information

Starting from runoff routing:

:HydrologicProcesses
  :Precipitation     PRECIP_RAVEN             ATMOS_PRECIP     PONDED_WATER          
  :Flush             RAVEN_DEFAULT            PONDED_WATER     SURFACE_WATER         
:EndHydrologicProcesses

Added the following lines to the .rvi file:

:Transport MRROS
:FixedConcentration MRROS ATMOS_PRECIP 0.1

For all headwater subbasins without reservoir, the Pollutograph is as expected (constant value of 0.1). For subbasins with reservoir (headwater or not), the Pollutograph is essentially zero - typical values range from -1e-12 to -1e-6.

Description

No response

Steps To Reproduce

No response

Additional context

No response

Contribution

BernardoTeufel commented 6 months ago

Issue is caused by unspecified DECAY_COEFF, which defaults to -33333.3 and results in negative mass (which results in concentrations reported as ~0). Fixed by setting negative values of DECAY_COEFF to zero.

analytophile commented 4 months ago

updated fix now in main code.