search

CSHS-CWRA / RavenPy

A Python wrapper to setup and run the hydrologic modelling framework Raven
https://ravenpy.readthedocs.io
MIT License
25 stars 5 forks source link

Open raven-hydro pin #351

Closed Zeitsperre closed 6 months ago

Zeitsperre commented 6 months ago

Changes

Additional information

It is very important that the upper pin is placed on raven-hydro as we have older/obsolete versions in conda-forge that were pinned to the versions of RavenHydroFramework. We dropped this convention in order to have more granular control over the version string.

It's unclear to me how we can fix this versioning on conda-forge without breaking older packages, but it should be mentioned that the older packages of RavenPy are broken anyway (the build-engine based on setuptools relied on direct downloads of the model source code using URLs that are no longer valid; i.e. we can no longer install the older versions of RavenPy from pip).

coveralls commented 6 months ago

Coverage Status

coverage: 81.619%. first build when pulling 5617469516b973a4eb6f93dd89c0fcfcdf66065d on open-raven-hydro-pin into 8f946019e7a5731eab9561776496af9a7dac403c on master.