Bug fix for notebooks - Githubissues

CSHS-CWRA / RavenPy

A Python wrapper to setup and run the hydrologic modelling framework Raven

https://ravenpy.readthedocs.io

MIT License

25 stars 5 forks source link

Bug fix for notebooks #360

Closed huard closed 5 months ago

huard commented 5 months ago

Fixed custom output command not rendering correctly Convert config and output paths to absolute paths

coveralls commented 5 months ago

coverage: 81.67% (-0.09%) from 81.756% when pulling 8f9aa1537692c7a4a793c728fbfc22403117e855 on fix_custom_output into e60d7043d1a873172b0993f3f98e68d4ec6c1af9 on master.

tlvu commented 5 months ago

Is this PR compatible with the current Jupyter env and can be merged immediately or this PR is only for the upcoming Jupyter env and have to wait for that one to go live before this PR can be merged?

If this is for the upcoming Jupyter env only, can this PR be merged to the branch fixnbs_pavics_betaimage (https://github.com/CSHS-CWRA/RavenPy/pull/356) from Travis so I can test all upcoming changes together?

huard commented 5 months ago

It's a bugfix that I believe is compatible with the current env.