Update routing_product.py

CSHS-CWRA / RavenPy

A Python wrapper to setup and run the hydrologic modelling framework Raven

https://ravenpy.readthedocs.io

MIT License

26 stars 5 forks source link

Update routing_product.py #401

Closed lou-a closed 2 months ago

lou-a commented 2 months ago

Modified routing_product.py to correctly set the river length to zero and set default values for reach attributes in sub-basins with no channel routing (i.e., sub-basins with lakes or headwater basins).

Pull Request Checklist:

[X] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #354
[ ] (If applicable) Documentation has been added / updated (for bug fixes / features).
[x] (If applicable) Tests have been added.
[x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Other information:

github-actions[bot] commented 2 months ago

Welcome, new contributor!

It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the AUTHORS.rst and .zenodo.json:

[x] The relevant author information has been added to AUTHORS.rst and .zenodo.json.

Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨

coveralls commented 2 months ago

coverage: 81.343% (+0.1%) from 81.238% when pulling 74a6bd36cbeea57d3bf2b412718a214dc2792fc9 on routing-product-fixes into 877869420fc792132b2f384a2bac5e34e44c43c3 on master.

lou-a commented 2 months ago

Just add a note in the CHANGELOG, and a test to confirm everything is working as you expect.

@huard, let me know whether the tests seem ok. It's my first time coding tests 🤓