update notebook to adapt to new RavenHydroFramework conventions

CSHS-CWRA / RavenPy

A Python wrapper to setup and run the hydrologic modelling framework Raven

https://ravenpy.readthedocs.io

MIT License

26 stars 5 forks source link

update notebook to adapt to new RavenHydroFramework conventions #406

Closed Zeitsperre closed 1 month ago

Zeitsperre commented 1 month ago

Fixes 1/2 of https://github.com/Ouranosinc/pavics-jupyter-env-issues/issues/12

FYI @tlvu

Changes

Updates the ForcingPetrurbation to use average temperature and not max and min temperature.

tlvu commented 1 month ago

Cool, thanks ! I will test this with the new Jupyter env build. Please let me merge this PR so it is synchronized with the new Jupyter env go-live.

coveralls commented 1 month ago

coverage: 81.343%. remained the same when pulling a02c593bfe1ec65f03eb7eeb4b1f02f1f7cca450 on fix-pjei-12-2 into 86d63062c83e490b4fadc8cd684b3c0a629f33e9 on master.

tlvu commented 1 month ago

This PR has been merged into PR https://github.com/CSHS-CWRA/RavenPy/pull/395