HBVEC emulator improvement - Githubissues

CSHS-CWRA / RavenPy

A Python wrapper to setup and run the hydrologic modelling framework Raven

https://ravenpy.readthedocs.io

MIT License

26 stars 5 forks source link

HBVEC emulator improvement #408

Closed lou-a closed 1 month ago

lou-a commented 1 month ago

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes #xyz
[ ] (If applicable) Documentation has been added / updated (for bug fixes / features).
[ ] (If applicable) Tests have been added.
[X] CHANGELOG.rst has been updated (with summary of main changes).
- [X] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Added an alias for rain snow fraction to match other emulators.

Does this PR introduce a breaking change?

This minor change should not lead to any breaking changes and it should be covered by emulator tests already included in the repo.

Other information:

coveralls commented 1 month ago

coverage: 81.343%. remained the same when pulling 61310e3a7de600703bd47ecd7db1dff380dff324 on hbvec-improvement into 86d63062c83e490b4fadc8cd684b3c0a629f33e9 on master.