Issue #29 - Update styles to match guidelines

CSI-280 / MusicGames

0 stars 0 forks source link

Issue #29 - Update styles to match guidelines #49

Closed jbuzzell closed 4 years ago

jbuzzell commented 4 years ago

Some styles, such as those to do with the current game page nav, have not been changed. These styles do not match with the guidelines, but require further consideration or complete redesign.

closes #29

jbuzzell commented 4 years ago

specifically left out the game page nav from style updates. i would rather see this as a dropdown in the navbar than a feature on the page.

jbuzzell commented 4 years ago

@CSI-280/web-people anyone who feels so inclined to review is welcome. sorry this is coming in late.

JakeCapra commented 4 years ago

I liked the bigger gamenav buttons better. I do like the space you added on the left, however.

jbuzzell commented 4 years ago

oh wow, i didn't even mean to change that. i'll fix that and commit & i imagine it should be good to go after that

jbuzzell commented 4 years ago

updated to make the buttons bigger and to make the game layout look a little better. i used css grid this time too so it should be more responsive.

JakeCapra commented 4 years ago

Looks good, can you make the whole rectangle a link, and not just the text? Also, I think that this broke the tic tac toe reset button, it's not under the board anymore:

jbuzzell commented 4 years ago

yeah, i can fix that.

oh jesus i forgot about the reset button. i'm not actually sure how that's rendered, i'll give it a look.

jbuzzell commented 4 years ago

ok, fixed some of the issues. i couldn't get the reset button to be left aligned with the board so i centered it.

should we make the button red when you lose and green when you win? i just have it following the basic styleguide right now

jbuzzell commented 4 years ago

@CSI-280/web-people bump

A-Waters commented 4 years ago

Uh I mean if it's not a lot of work it might be a nice touch, but we should be consistent over the website.

jbuzzell commented 4 years ago

@CSI-280/web-people this still hasnt been formally approved, can someone look at it? if i don't hear back i'll probably merge by like 3 or something along with any other style updates for the presentation

A-Waters commented 4 years ago

You haven't requested anyone to review it... but there are some merge conflicts. @jbuzzell

jbuzzell commented 4 years ago

yeah i can handle the merge conflicts. my bad i didn't actually assign any reviewers, i just tagged everyone.

jbuzzell commented 4 years ago

ignore this, i'm going to include the changes in my pr for #69

jbuzzell commented 4 years ago

as #77 implements these changes but better i'm closing this