search

CSI-280 / MusicGames

0 stars 0 forks source link

clearning console and read me and fixed spotify client #63

Closed A-Waters closed 4 years ago

A-Waters commented 4 years ago

Simple stuff,

Just went through all the warnings in the console and fixed them and move some info around in the read me, specifically around the APIs and installing dependencies.

if I missed something lmk.

A-Waters commented 4 years ago

I also ended up fixing the Spotify client on this request instead of branching off a new branch,

NathanDiMauro commented 4 years ago

@lenora4321 can you review this so we can work on the other games that need the spotify client

A-Waters commented 4 years ago

Doesn't work, spotify is trash, working on fix.

A-Waters commented 4 years ago

Basically the issue is because Spotify API tokens expire after one hour, unlike most APIs which expire after 60 days. So now we need a way to distribute keys among us and being able to rewrite them as needed so I'm working on that now. I'm also thinking about saying "screw security" just to get it working.

A-Waters commented 4 years ago

big dumb by Spotify but basically it gets an access token each time the project is run, so yay. I'm not sure if the refresh token is gonna need updating tho (according to some sources its good forever). if the token ever fails and needs a refresh mid-use, I think I set it up to request a new one automatically.

all good to merge @NathanDiMauro