CSIRO-enviro-informatics / asgs-dataset

GNU General Public License v3.0
0 stars 1 forks source link

Is Australia being harvested correctly in the cache. #6

Open shaneseaton opened 5 years ago

shaneseaton commented 5 years ago

There is a concept of Australia in the Reg of Regs, and it has a ttl representation too, but not sure its being harvested correctly for the main cache

dr-shorthair commented 5 years ago

Yeah - there is a register (dataset)

<http://linked.data.gov.au/dataset/asgs2016/australia/> 
    a reg:Register ;
    reg:register <http://linked.data.gov.au/dataset/asgs2016/reg/> .

but no corresponding (singleton) member of this dataset. If it were similar to

<http://linked.data.gov.au/dataset/asgs2016/stateorterritory/VIC>
   a <http://linked.data.gov.au/def/asgs#StateOrTerritory> , geo:Feature ; 
   reg:register <http://linked.data.gov.au/dataset/asgs2016/stateorterritory/> . 

then you might expect

<http://linked.data.gov.au/dataset/asgs2016/australia/AU>
    a <http://linked.data.gov.au/def/asgs#Country> , geo:Feature ;
    reg:register <http://linked.data.gov.au/dataset/asgs2016/australia/> ;
    geo:sfContains <http://linked.data.gov.au/dataset/asgs2016/stateorterritory/VIC> , 
                   <http://linked.data.gov.au/dataset/asgs2016/stateorterritory/NSW> , 
                   <http://linked.data.gov.au/dataset/asgs2016/stateorterritory/WA> , ... .
ashleysommer commented 5 years ago

@dr-shorthair

then you might expect

http://linked.data.gov.au/dataset/asgs2016/australia/AU a http://linked.data.gov.au/def/asgs#Country , geo:Feature ;

Actually the registry is: http://linked.data.gov.au/dataset/asgs2016/australia/ , not /country/ (just noticed you already fixed that up in your comment) and the feature instance is http://linked.data.gov.au/dataset/asgs2016/australia/036 because who knows why.

@shaneseaton It was never harvested because its just a single instance, and the register is a register with one thing in it. It would pretty easy to add it into the harvest routine.

dr-shorthair commented 5 years ago

A set with a single member is still a set!

jyucsiro commented 5 years ago

Should the name of the register be called Country given that that is the featureType?

dr-shorthair commented 5 years ago

If the feature-type is part of the URI, then there should be a common pattern across all feature-types.

Class Register Instance
http://linked.data.gov.au/def/asgs#MeshBlock http://linked.data.gov.au/dataset/asgs2016/meshblock http://linked.data.gov.au/dataset/asgs2016/meshblock/50259230000
http://linked.data.gov.au/def/asgs#StatisticalAreaLevel1 http://linked.data.gov.au/dataset/asgs2016/statisticalarealevel1 http://linked.data.gov.au/dataset/asgs2016/statisticalarealevel1/50102100504
http://linked.data.gov.au/def/asgs#StatisticalAreaLevel2 http://linked.data.gov.au/dataset/asgs2016/statisticalarealevel2 http://linked.data.gov.au/dataset/asgs2016/statisticalarealevel2/308031218
http://linked.data.gov.au/def/asgs#StatisticalAreaLevel3 http://linked.data.gov.au/dataset/asgs2016/statisticalarealevel3 http://linked.data.gov.au/dataset/asgs2016/statisticalarealevel3/80106
http://linked.data.gov.au/def/asgs#StatisticalAreaLevel4 http://linked.data.gov.au/dataset/asgs2016/statisticalarealevel4 http://linked.data.gov.au/dataset/asgs2016/statisticalarealevel4/207
http://linked.data.gov.au/def/asgs#StateOrTerritory http://linked.data.gov.au/dataset/asgs2016/stateorterritory http://linked.data.gov.au/dataset/asgs2016/stateorterritory/2
http://linked.data.gov.au/def/asgs#Country http://linked.data.gov.au/dataset/asgs2016/country http://linked.data.gov.au/dataset/asgs2016/country/61

The register name includes the feature-type in lower-case (recommended pattern for instance data). I suggest no trailing "/" in the canonical form. A request for one with a trailing "/" it should just be redirected to the no-trailing-/ address.

I used "61" as the country code ...

dr-shorthair commented 5 years ago

FWIW - this diagram https://www.abs.gov.au/websitedbs/D3310114.nsf/home/Australian+Statistical+Geography+Standard+(ASGS) has 'Australia' at the top, rather than 'Country' which is probably the source of the ambiguity.

ashleysommer commented 5 years ago

@dr-shorthair in the ABS dataset (accessed via their WFS endpoint) the feature class type is "Australia" and the instance name is "036", see it represented here: http://linked.data.gov.au/dataset/asgs2016/australia/036

dr-shorthair commented 5 years ago

So the class name in the ontology is inconsistent with the ABS documentation. This is something to bounce back to Laurent at ABS I think.

dr-shorthair commented 5 years ago

See https://github.com/AGLDWG/asgs-ont/issues/5