search

CSIRO-enviro-informatics / loci-integration-api

This application provides a convenient interface for executing common functions across the whole LOCI system.
0 stars 3 forks source link

Bugs in hierarchy_overlap /location/overlaps implementation #38

Closed jyucsiro closed 4 years ago

jyucsiro commented 4 years ago

On the PR #36, found some bugs that the previous version did not have. Should be backwards compatible, where crosswalks=false...

1. Find overlaps for a CC

This works in master: https://api2.loci.cat/api/v1/location/overlaps?uri=http%3A%2F%2Flinked.data.gov.au%2Fdataset%2Fgeofabric%2Fcontractedcatchment%2F12101547&areas=true&proportion=true&contains=false&within=false&crosswalk=false&count=1000&offset=0

In the hierarchy_overlaps, the same query causes an internal server error (local deployment): http://localhost:8080/api/v1/location/overlaps?uri=http%3A%2F%2Flinked.data.gov.au%2Fdataset%2Fgeofabric%2Fcontractedcatchment%2F12101547&areas=true&proportion=true&contains=false&within=false&crosswalk=false&count=1000&offset=0

2. Find overlaps incl. wholly contained for a CC

In the master branch, this works (i.e. contains=true): https://api2.loci.cat/api/v1/location/overlaps?uri=http%3A%2F%2Flinked.data.gov.au%2Fdataset%2Fgeofabric%2Fcontractedcatchment%2F12101547&areas=true&proportion=true&contains=true&within=false&count=1000&offset=0

In the hierarchy_overlaps, the same query causes an internal server error (local deployment): http://localhost:8080/api/v1/location/overlaps?uri=http%3A%2F%2Flinked.data.gov.au%2Fdataset%2Fgeofabric%2Fcontractedcatchment%2F12101547&areas=true&proportion=true&contains=true&within=false&count=1000&offset=0

3. Find overlaps incl. features that a CC is within

In the master branch, this works (i.e. within=true): https://api2.loci.cat/api/v1/location/overlaps?uri=http%3A%2F%2Flinked.data.gov.au%2Fdataset%2Fgeofabric%2Fcontractedcatchment%2F12101547&areas=true&proportion=true&contains=false&within=true&count=1000&offset=0

In the hierarchy_overlaps, the same query causes an internal server error (local deployment): http://localhost:8080/api/v1/location/overlaps?uri=http%3A%2F%2Flinked.data.gov.au%2Fdataset%2Fgeofabric%2Fcontractedcatchment%2F12101547&areas=true&proportion=true&contains=false&within=true&count=1000&offset=0

benjaminleighton commented 4 years ago

Fixed