CSIRO-enviro-informatics / loci.cat

Latest updates from the Loc-I Project
https://loci.cat
Other
0 stars 1 forks source link

Update SPARQL queries to match new ontology descriptions when new cache available #49

Open jyucsiro opened 4 years ago

dr-shorthair commented 4 years ago

Some work started here https://github.com/CSIRO-enviro-informatics/loci-integration-api/pull/47

benjaminleighton commented 4 years ago

@dr-shorthair can you comment on https://github.com/CSIRO-enviro-informatics/loci-cache-scripts/blob/master/docker/cache/resources/pre-condition-files/008_dataset_def.sparql does that need changing? I know there are somethings in there that maybe we don't need like the named individual stuff we can change that in another issue but is there anything effected by changes you know of?

jyucsiro commented 4 years ago

@benjaminleighton can we close this?

dr-shorthair commented 4 years ago

I think the query that Ben pointed me at in https://github.com/CSIRO-enviro-informatics/loci.cat/issues/49#issuecomment-598532779 might be simplified by removing the

            a owl:NamedIndividual ;

from each insert. From a semantic POV there is no need for this assertion. However, perhaps you guys use this classifier somewhere else in the queries?

benjaminleighton commented 4 years ago

@jyucsiro and @dr-shorthair you are probably both in a better position to decide whether to close this and also to close out https://github.com/CSIRO-enviro-informatics/loci-integration-api/pull/47 at the same time. I believe that 47 is mostly solved through another pull request you made Jonathan? Looking through that pull request here are the things to be considered:

Is there anything else that changed, structurally, that we need to account for? I'm guessing there aren't any direct dependencies in excelerator on iderdown now either but it might be worth checking with @shaneseaton .