search

CSIRO-enviro-informatics / pyldapi

A very small module to add Linked Data API functionality to a Python Flask installation
GNU General Public License v3.0
1 stars 0 forks source link

Why are directories _config, controller, model, in the repository? #6

Closed ashleysommer closed 6 years ago

ashleysommer commented 6 years ago

There are empty directories _config, controller, model, in the repository. They only contain old cache files, and none of these directories seem to be used in the project.

nicholascar commented 6 years ago

_config/ shouldn't be there. A specific implementation of this module would need a _config/ folder with config vars in a initi.py file with local config, passwords etc. Presume folder is there due to an accidental commit to a child file.

Likewise for controller/ & model/: these are implementation-specific folders (I typically use an MVC with a model, view & controller folder). Must be there due to accidental child file commits

nicholascar commented 6 years ago

I should remove these folders

nicholascar commented 6 years ago

fixed by https://github.com/CSIRO-enviro-informatics/pyldapi/commit/60c29e3cbe4c734806a765c39c8f4cad1469cb72