Bugs and Other Notes - Githubissues

aleesteele commented 5 years ago

Bugs: Oceans Website Note: Some of the bugs I'm seeing might be because I have a different height/width screen ratio.

Bugs

[x] I'm not sure if this is on purpose, but the spotlight navigation doesn't reach the bottom of the screen on my computer. (See screenshot below) L
- It should reach the bottom, please -T
[x] The Spotlight navigation also appears to be a little buggy. Clicking on the appropriate section sometime doesn't show the appropriate dash (–) next to it. Also, the title of the section appears at various places on the screen when this is done. L
- I haven't seen the dash thing, but we should look at the anchor/scroll location. Right now the title isn't visible on the screen once the page is done scrolling. -T
[x] Not sure if this will be added in later, but the 'Mailing list' link doesn't go anywhere. *J
[x] ~You can still scroll through the content while the mobile Spotlight menu is open on mobile/smaller screens. The red progress bar loads.~ Not a bug
[x] Home page: PRESERVE doesn't show up on mobile screens (checked on iPhone) J
[x] On the spotlight, changing the single image (ie the AIS signals map) to 'small' actually increases its size. L
- There isn't a 'small' size for single images that aren't floated, but I was having a similar problem with the 'medium' size. Please fix! -T

Other

[x] ~I'm not sure if this is on purpose, but there's a bit space between the SOS description and the copyright info.~ I noted this in my design issue -T
[x] ~On mobile, Greg’s bio stays aligned to the left after being previously centered. Screenshot below. Not sure if on purpose.~ That's on purpose. It's difficult to read longer paragraphs that are center-aligned. -T
[x] On mobile, the animated scroll gets kinda wonky for the waves (you can pause scrolling mid-way between the wave and the sky. J
[x] ~On the homepage, the main video plays on mobile screens within the design elements. Not sure if it should auto-expand to full-screen on mobile devices.~ Not a bug

jnschrag commented 5 years ago

@aleesteele I've added comments to a few of these that are not bugs. Can you please add clarifying information to these:

Changing the GIF size to 'small' actually makes it large.

What GIF?

About page: right column isn’t white/no pseudo element. Not sure if on purpose.

Are you referring to the dark background on the right side? If so, that is intentional. It isn't supposed to be white all the way across the page.

When the video plays on mobile screens, not sure if it should auto-expand to full-screen.

What video?

aleesteele commented 5 years ago

@jnschrag I went through the notes and edited them accordingly! By video, I had meant the one on the homepage, and I had made a mistake with the GIF note. I actually meant the AIG signals single image, and added a screenshot of what I meant to the list.

aleesteele commented 5 years ago

Added a couple more notes w/ screenshots (@jnschrag @leezaweb @tuckabelle)

[x] Going off of what Tucker said about how Greg's bio is staying aligned to the left b/c it's a block of text, should the bios be changed? A
- Yes, please left align this on mobile
[x] Not sure about arrow placements on mobile of these, figured they are centered on the screen to account for photos (however they are oriented). Figured I'd add this to the list. L
[x] There's a big space between the published date and the lede for this post, because it includes a photo I think. Not sure if this is a design spec or error, but you can see it on Greg's author page. None of the commentaries have photos so this isn't shown elsewhere. L
[x] Figured you all were working on the homepage, but the letter spacing is different on mobile for "PROTECT"
[x] On smaller screens, the footer coral image is pretty pixelated. Is the 'small' size footer image being used for medium screens? $img__footer variable has all needed sizes. L

aleesteele commented 5 years ago

Edge

[x] Spotlight sticky header text is centered
[x] Object fit isn't working on video ¿https://www.npmjs.com/package/object-fit-videos?

Internet Explorer

I bolded the ones that seemed most important. Everything seems to render well for EDGE, but will do more extensive testing tomorrow.

[x] The search function/search bar doesn't appear when clicked for IE.
- UPDATE, the search bar works on IE, but no longer on Chrome. Also it doesn't take up the full width of the page?
[x] Some of the formatting on the Homepage is funky for IE&. Neither PROTECT nor PRESERVE show up on internet Explorer on the Homepage. Also, the SPOTLIGHTS section formatting doesn't render. I know the homepage is currently being worked on, so this is just a note. The left is IE, the right is EDGE.
[x] The header menu doesn't retain it's opacity when the user scrolls down for IE. (see below)
[x] Pagination does not appear on archive pages at all for IE. (Although there's only one page, nothing shows up in the bottom right at all. In the screenshot below, left is IE, right is EDGE)
[x] On the archive pages, the photo used for the SCS preview is stretched out for IE. In the screenshot below, the left is IE, the right is EDGE.
[x] On the author page, Whit's image is stretched out. This might be because there isn't a max-height on the image. In the screenshot below, the left is IE, the right is Chrome.
[x] The galleries were a little distorted for the image pairs in IE, the screenshots of which are below. The 6 images loaded in full height/width, also shown below. Left is IE, right is Chrome.
[x] Nav loading bar doesn't appear, along with menu and title change. T=In the screenshot below, left is IE, right is Chrome.
[x] Map GIF doesn't appear + tooltip doesn't load in IE. In the screenshot below, left is IE, right is Chrome.
[x] Scrollytelling loads with a single single + separately scrolling text. The image doesn't remain static while the next loads. In the screenshot below, left is IE, right is Chrome.
[x] Floating first right element uses a different fall-back accent-color in IE