search

CSIS-iLab / trade_guys

Trade Guys landing page/web hub
https://tradeguys.csis.org
MIT License
0 stars 3 forks source link

Boeing viz/scrollytelling #74

Closed dlousa92 closed 5 years ago

dlousa92 commented 5 years ago

Here's the initial pull request. I created a new branch "booeing-viz/scrollytelling" and I'm working off that. I added the new svg that removed all that whitespace. I also added opacity to the background of the paragraphs (Are you honed in on making those backgrounds white? Was playing around with transparent gray and it looked nice on my end) . I Had to play around with margin values a little bit and the timing of the waypoint triggers so that the paragraphs look nice.

Also there are a lot of commits that Anne made previously here.

dlousa92 commented 5 years ago

Thank you for the notes! I'll make these fixes.

dlousa92 commented 5 years ago

I've made the suggested changes. Three things I noticed

  1. I couldn't find anywhere where the .timer class was being used so I just removed it.

  2. I rearranged base.scss to apply styles specifically to elements in the interactive, but I wasn't sure about the .wrapper class styles. I moved them into what I think is more applicable and specific, but let me know if that's not quite right.

  3. Updating the .gitignore didn't quite work. I think the path might be incorrect? I tried a couple of different paths but couldn't get it to work. In addition to /assets/js/**/*.js.map I tried /assets/js/**/**/*.js.map

jnschrag commented 5 years ago

@dlousa92 The .wrapper styles can be left as they were. We talked about what that is for yesterday.

Re the .gitignore, the reason why it isn't working is because the .map file has already been stored in the repo. So you'll need to create a new commit that removes it from the remote repo. You can do that like this:

git rm --cached /assets/js/**/*.js.map
git commit -m "remove .map from repo"
dlousa92 commented 5 years ago

ahhh, got it thank you.