search

CSIS-iLab / trade_guys

Trade Guys landing page/web hub
https://tradeguys.csis.org
MIT License
0 stars 3 forks source link

Boeing viz/scrollytelling #75

Closed dlousa92 closed 5 years ago

dlousa92 commented 5 years ago

Hey Jacque,

This pull request is for highlighting parts on the plane svg in and out as a user scrolls down through the page. I changed the previous code a bit and I'm now using the Previous method provided in the Waypoints documentation here: http://imakewebthings.com/waypoints/api/previous/

With this I'm fading pieces and labels out as each section is passed. Take a look and let me know what you think! I think I can make the counter code much simpler using the Next method as well.

Next, I need to add behaviour for if a user decides to scroll up (😪), but I wanted to submit this so you get an initial look and let me know if you want me to change anything.

dlousa92 commented 5 years ago

Thank you for the review! I'll go ahead and start implementing these changes.

dlousa92 commented 5 years ago

Thank you for all the great feedback Jacque,

I'm really learning a ton working on this project. I implemented these changes as suggested!