Closed prust closed 9 years ago
@Suor: I made some minor tweaks to your pull request, mostly code style, but also switched to an alternative method of using apply()
with new
.
Please let me know if this works for you (I did test it with an empty extension and applied the applyNew()
change to sql-bricks-postgres and the tests there passed, but I haven't run the sql-bricks-postgres tests with all these changes)
I found a bug (my own) and fixed it in https://github.com/CSNW/sql-bricks/pull/57.
This is an iteration on @Suor's #55:
is_common_js
orwindow.process &&
; checkingprocess &&
throws an error) fcb56dbconstruct()
toapplyNew()
(both are answers to http://stackoverflow.com/q/1606797/194758,construct()
is most popular, but I prefer the second most popular withctor.bind.apply()
-- it's a little harder to understand, but it seems cleaner to me) 9ce29e9_extension()
at the top 9ce29e9hasOwnProperty()
to_.keys()
, which doeshasOwnProperty()
check if necessary and handles IE<9 edge-case 9ce29e9, f595b88