search

CSNW / sql-bricks

Transparent, Schemaless SQL Generation
http://csnw.github.io/sql-bricks
MIT License
204 stars 25 forks source link

Remove buggy array support #81

Closed prust closed 7 years ago

prust commented 8 years ago

Remove sql-bricks buggy (see #78) array support (sql-bricks doesn't need to implement arrays, since they're part of SQL-99).

Ensure that it's easy for end-users and sql-bricks-postgres to implement array support, document how to do this and encourage users to create and maintain a sql-bricks-99 extension to sql-bricks if they so desire.

prust commented 7 years ago

@Suor: FYI, I just gave SQLBricks a major version update (to 2.0.0), but only because of the 1 non-backwards-compatible change introduced in this pull request (removing built-in array support). This shouldn't affect sql-bricks-postgres & shouldn't require a major rev on your part, since you're already supplying your own sql.conversions.Array in https://github.com/Suor/sql-bricks-postgres/commit/87d3a4d

Suor commented 7 years ago

Thanks for heads up.