CSOIreland / PxStat

Data Dissemination Management System for publishing Statistics in Open Data formats.
MIT License
34 stars 7 forks source link

[BUG] Reasons missing from "PxStat.Data.Cube_API.ReadMetadata" #584

Closed damienderoistecso closed 2 years ago

damienderoistecso commented 2 years ago

Reasons are not included in the JSONstat for "PxStat.Data.Cube_API.ReadMetadata"

neilfromcork commented 2 years ago

Fixed in DEV - ready for test

damienderoistecso commented 2 years ago

@liamie Can you test this

liamie commented 2 years ago

Reasons are now appearing in the jsonstat Null if empty

"extension": { "matrix": "NQQ50", "reasons": [ "external test" ], "language": { "code": "en", "name": "English" },

"extension": { "matrix": "CDR09", "reasons": null, "language": { "code": "ga", "name": "Gaeilge" },

liamie commented 2 years ago

re opened as now reasons appearing twice?

damienderoistecso commented 2 years ago

re opened as now reasons appearing twice?

@neilfromcork It appears as if ReadMetadata is correct and returns the reasons as they should be but ReadDataset returns the same reason twice in the same reasons array in the extension

liamie commented 2 years ago

Reasons appearing once and only once now