[ENHANCEMENT] excel metadata labels taken from the PxLanguagePlugins

CSOIreland / PxStat

Data Dissemination Management System for publishing Statistics in Open Data formats.

MIT License

34 stars 7 forks source link

[ENHANCEMENT] excel metadata labels taken from the PxLanguagePlugins #840

Open DisseminationNI opened 6 months ago

DisseminationNI commented 6 months ago

When creating the metadata page in an excel download, pull the label names from the PxLanguagePlugins client folder

https://github.com/CSOIreland/PxLanguagePlugins/blob/main/client/en.json

For example in the CSO excel download, properties is displaying an 'Experimental' flag rather than the Frontier Series that is in the PxLanguagePlugins

neilfromcork commented 6 months ago

I can't reproduce this problem. Can you check that the right hand side of the "experimental" field on the language.json file is as shown below:

DisseminationNI commented 6 months ago

I have attached an excel download of a CSO dataset, the properties section is showing the names on the left hand side rather than the right HR026.20240325T080353.xlsx

The names we use are different however they also aren't coming through on the excel download

neilfromcork commented 6 months ago

OK - can you remind me which version of PxLanguagePlugins you are using at the moment? Thanks

neilfromcork commented 6 months ago

Can you go to a file on the server called server.json? Have a look at the language setting as shown below and make sure that the translation url it points to is the version that contains the correct mapping for NISRA:

DisseminationNI commented 6 months ago

I have moved to the latest version of PxLanguagePlugins (2.3.1) and added the translationUrl line to the server.json file. The version of PxStat that we are on was released May 2023 (5.6.1) and from the issues log the translationUrl was added in June 2023 so it could be that the code isn't in the version we are on

neilfromcork commented 6 months ago

Yes, the general method for linking to the language file was changed between those versions. And the method was changed again for version 6.0.0.

In any case, we need to start talking about version 6.0.0 (which will be needed anyway in order to run the enhancement regarding release frequency). This will be the first version to use .Net Core and, because Microsoft decided to completely rewrite their architecture for web applications, there is a bit more effort than usual required for the version upgrade.

We will contact you very soon in order to discuss how we might manage this upgrade.

neilfromcork commented 1 month ago

Fixed in DEV